Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS file #81

Merged
merged 1 commit into from
May 24, 2024
Merged

add CODEOWNERS file #81

merged 1 commit into from
May 24, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Having a CODEOWNERS file better defines ownership of code for maintenance and also ensures that the right people are automatically tagged to review any code changes, both of which are beneficial to security

@markdboyd markdboyd requested a review from a team May 24, 2024 19:54
@markdboyd markdboyd enabled auto-merge (squash) May 24, 2024 19:55
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing

@markdboyd markdboyd merged commit dccf90d into main May 24, 2024
1 check passed
@markdboyd markdboyd deleted the add-codeowners branch May 24, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants