Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Refactor the ci pipeline to improve dry-ness #251

Merged
merged 1 commit into from
Jul 9, 2024
Merged

chore(ci): Refactor the ci pipeline to improve dry-ness #251

merged 1 commit into from
Jul 9, 2024

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Jul 8, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Refactors pipeline to use the latest functionality from pages-pipeline-tasks
  • Removes redundant task code and config for node install and builds
  • Creates two deploy envs dev and deploy that are set via the boot task's ENV_OVERRIDE

Security considerations

None

@apburnes apburnes requested a review from a team July 9, 2024 14:38
svenaas
svenaas approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@svenaas svenaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like set-pipeline ran as of the last commit, and test-redirects is OK.

@apburnes apburnes merged commit 25a28d8 into main Jul 9, 2024
3 checks passed
@apburnes apburnes deleted the chore-ci-refactor-pipelines branch July 9, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenaas svenaas svenaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apburnes @svenaas