chore: Test frontend/pages/sites/SiteListItem.jsx (#4965) and fronten… #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
5 tasks
sknep
commented
Dec 18, 2024
sknep
commented
Dec 18, 2024
|
|
||
| import SiteListItem from './SiteListItem'; | ||
| // import GitHubLink from '@shared/GitHubLink'; | ||
| // import PublishedState from './PublishedState'; |
There was a problem hiding this comment.
Should I be stubbing these instead?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I had to do this slightly differently with expect.objectContaining() and expect.anything()
LMK what you think
sknep
commented
Dec 18, 2024
sknep
commented
Dec 18, 2024
sknep
commented
Dec 18, 2024
| @@ -86,11 +63,6 @@ SiteListItem.propTypes = { | |||
| viewLink: PropTypes.string, | |||
There was a problem hiding this comment.
i'm not sure about viewLink -- i wonder if it was what the link used to link to before we decided to make it the build history?
🤖 This is an automated code coverage reportTotal coverage (lines): 17.94% |
apburnes
reviewed
Dec 18, 2024
apburnes
reviewed
Dec 18, 2024
|
|
||
| import SiteListItem from './SiteListItem'; | ||
| // import GitHubLink from '@shared/GitHubLink'; | ||
| // import PublishedState from './PublishedState'; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sknep
force-pushed
the
chore-test-pages/sites/SiteListItem-and-PublishedState-4691-4695
branch
from
f0d20f1 to
962f2bd
Compare
sknep
force-pushed
the
chore-test-pages/sites/SiteListItem-and-PublishedState-4691-4695
branch
2 times, most recently
from
0b6cdb3 to
a55c7ee
Compare
… frontend/pages/sites/PublishedState.jsx
sknep
force-pushed
the
chore-test-pages/sites/SiteListItem-and-PublishedState-4691-4695
branch
from
a55c7ee to
0a53abf
Compare
apburnes
reviewed
Dec 19, 2024
apburnes
approved these changes
Dec 19, 2024
sknep
deleted the
chore-test-pages/sites/SiteListItem-and-PublishedState-4691-4695
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
<Link>directlysecurity considerations
N/A - just a few tests