ignore deprecation warnings from updated packages #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
We have upgraded to
cryptography > 43
becausepyca/cryptography
has vulnerabilities for >= 37.0.0, < 43.0.1To upgrade
cryptography
, we had to updatepyopenssl
, since pyopenssl doesn't support cryptography > 43 until version 24.2.0.However, pyopenssl 24.2.0 deprecates X509Req, which leads to these errors:
This issue is noted in certbot/josepy#181 and discussed in certbot/josepy#182.
Unfortunately, there is no clear fix for this issue right now. The maintainers of josepy are considering abandoning it for a new library, but there is no timeline on that change: certbot/certbot#8322
However, it seems like it is safe to ignore these warnings as long as we don't upgrade to josepy 2.x, as discussed in certbot/certbot#9993.
This PR ignores the deprecation warning and adds a version constraint to ensure that we don't upgrade to josepy 2.x
Things to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
Ignoring the deprecation warnings allows us to stay on newer package versions, which include patches for known security issues