Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsubscribe pending confirmation #393

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • Update unsubscribe_notification_topic to not throw error if the subscription is still pending confirmation and cannot be unsubscribed. This will fix failing integration tests where the subscription is never actually confirmed while the tests are running

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just fixing broker behavior

@markdboyd markdboyd requested a review from a team as a code owner September 25, 2024 17:37
@markdboyd markdboyd merged commit 68c5dce into main Sep 25, 2024
1 check passed
@markdboyd markdboyd deleted the handle-unsubscribe-pending-confirmation branch September 25, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants