Clean up code #98
Merged
Clean up code #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
commented
Nov 13, 2024
Comment on lines
-95
to
-113
| # add route for auth proxy job | ||
| - type: replace | ||
| path: /instance_groups/name=opensearch_dashboards/jobs/name=route_registrar? | ||
| value: | ||
| consumes: | ||
| nats-tls: | ||
| deployment: cf-development | ||
| from: nats-tls | ||
| name: route_registrar | ||
| properties: | ||
| route_registrar: | ||
| routes: | ||
| - name: opensearch-auth-proxy | ||
| registration_interval: 2s | ||
| server_cert_domain_san: auth-proxy.opensearch.internal | ||
| timeout: 1s | ||
| tls_port: 8000 | ||
| release: routing | ||
|
|
There was a problem hiding this comment.
This is handled below by lines 115-131
deploy-logs-opensearch/opsfiles/enable-proxy-auth.yml
Lines 115 to 131 in a136d40
jameshochadel
approved these changes
Nov 13, 2024
JasonTheMain
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None, just cleaning up code