-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add welcome mat with homepage redirects #583
base: main
Are you sure you want to change the base?
Conversation
@echappen This looks so good already. Excited to see this (almost) live! I spotted a couple things in this branch; I know it’s still a WIP, so logging them here for when/if you’re ready for them. This is probably a setup thing on my end, but the blog area’s not loading for me: The leading on the main card is a little tight; could we increase it a bit? (Adding a It looks like the org picker is overlapping the main content area: And finally, will you be working the updated footer into this PR? (widescreen, small screen) (If it’s out of scope for this week, that’s great — let me know, and I’ll open a separate issue for implementation!) |
@beepdotgov Thanks for all this! Let's open up a separate issue to update the footer, as I think that will take some dedicated work and I wouldn't want that to hold up the rest. |
Thanks so much for the tip on the blog feed config, @echappen — it looks great now. I’d love to suggest a couple tiny tweaks, if you have a minute! Here’s the current state: Here’s a quick in-browser edit: Here’s the TLDR of what I changed:
Do those seem doable to you? (Also, it looks like the browser’s default link colors might be getting applied to links in that block; is that right? Can we apply our default blue for the dash?) |
- moves manage users page to /orgs/:org_id/users - makes /orgs/:org_id the welcome page - redirects from root (/) to one of your org welcome pages
We were allowing devs to bypass page authentication in a local environment. This was getting confusing as middleware redirections became more complex, so we're getting rid of this bypass in order to have the same login flow that we have when deployed.
@beepdotgov All doable! Just pushed those updates. |
@hursey013 I noticed that middleware wasn't triggering at all for initial page loads of the root url |
Blocked by #524
Changes proposed in this pull request:
/login
when navigating to root/
and not authenticated/orgs/:org_id
lastViewedOrgId
is set, take them to this org/orgs/:org_id
as specified in Create "welcome mat" for authenticated users #529https://cloud.gov/updates.xml
How to test
NEXT_PUBLIC_BLOG_FEED_URL=https://cloud.gov/updates.xml
to.env.local
uaa-docker
container (instructions)npm run dev-cf
/
- you should be redirected to UAA login/uaa-docker/uaa.yml
to log in/orgs/:org_id
Related issues
Closes #529
Submitter checklist
Security considerations
Uses org id stored in cookie to make CF API requests in order to show the content on the page