Add css class, remove upgrade-insecure-requests in dev

cloud-gov · Oct 30, 2024 · e81bdd2 · e81bdd2
1 parent 2a756bd
commit e81bdd2
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/__tests__/middleware.test.js b/__tests__/middleware.test.js
@@ -57,6 +57,10 @@ describe('/login', () => {
     expect(location).toMatch('state=baz');
     expect(location).toMatch('response_type=code');
   });
+
+  it('has CSP headers present', () => {
+    expect(response.headers.get('content-security-policy')).not.toBeNull();
+  });
 });
 
 describe('auth/login/callback', () => {

diff --git a/src/assets/stylesheets/styles.scss b/src/assets/stylesheets/styles.scss
@@ -108,14 +108,14 @@
     'palette-color-system-green-cool-vivid',
     'palette-color-system-red-cool-vivid',
     'palette-color-system-red-vivid'
-      // no trailing comma,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
+      // no trailing comma,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
   ),
 
   $border-color-palettes: (
     'palette-color-system-green-cool',
     'palette-color-system-red-vivid',
     'palette-color-system-gray-cool'
-      // no trailing comma,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
+      // no trailing comma,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
   ),
 
   $top-palettes: (
@@ -164,6 +164,9 @@
   text-overflow: clip;
   text-overflow: ellipsis;
 }
+.text-underline-offset {
+  text-underline-offset: 0.7em;
+}
 
 /* Custom selector styles */
 
@@ -429,7 +432,11 @@ $error-color-dark: 'red-40v';
 // ProgressBar
 
 .progress__bg--infinite {
-  background: linear-gradient(90deg, color('blue-cool-20v') 78.42%, color('blue-cool-30v') 100%);
+  background: linear-gradient(
+    90deg,
+    color('blue-cool-20v') 78.42%,
+    color('blue-cool-30v') 100%
+  );
 }
 
 .progress__infinity-logo {

diff --git a/src/components/Overlays/OverlayHeaderUsername.tsx b/src/components/Overlays/OverlayHeaderUsername.tsx
@@ -13,7 +13,7 @@ export function OverlayHeaderUsername({
 }) {
   return (
     <>
-      <h2 className="margin-top-0 margin-bottom-7 text-uppercase text-light underline-base-light text-underline font-sans-xs">
+      <h2 className="margin-top-0 margin-bottom-7 text-uppercase text-light underline-base-light text-underline text-underline-offset font-sans-xs">
         {header}
       </h2>
       {serviceAccount && (

diff --git a/src/middlewares/withCSP.ts b/src/middlewares/withCSP.ts
@@ -16,7 +16,7 @@ export const withCSP: MiddlewareFactory = (next: NextMiddleware) => {
         base-uri 'self';
         form-action 'self';
         frame-ancestors 'none';
-        upgrade-insecure-requests;
+        ${process.env.NODE_ENV !== 'development' ? 'upgrade-insecure-requests;' : ''};
       `;
 
     // Replace newline characters and spaces