Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws-list-unused-rds-databases.py #278

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Update aws-list-unused-rds-databases.py #278

merged 4 commits into from
Oct 11, 2023

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Oct 11, 2023

Changes proposed in this pull request:

  • Retrieve org name and space name from CF
  • Created "action" column with business logic on how to handle a particular entry
  • Fix to how db connections are calculated, switched to pulling stats by day and summing the results as to not miss any of the history by attempting to match period length to start/end time.

security considerations

None, relies on aws-vault and cf oauth-token for access

@cweibel cweibel requested a review from a team October 11, 2023 13:34
@cweibel cweibel merged commit b46eda2 into main Oct 11, 2023
@cweibel cweibel deleted the unused-rds branch October 11, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdboyd markdboyd markdboyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cweibel @markdboyd