Merge remote-tracking branch 'mpevnev/avoid-lazy-concat-in-select' in…

…to stack
clojurephant · Aug 14, 2022 · 32a98bf · 32a98bf
2 parents 9d891a8 + 1d3e723
commit 32a98bf
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/src/main/clojure/dev/clojurephant/jovial/engine.clj b/src/main/clojure/dev/clojurephant/jovial/engine.clj
@@ -128,13 +128,7 @@
 (defn select [^EngineDiscoveryRequest request ^UniqueId id]
   (let [listener (.getDiscoveryListener request)
         selectors (.getSelectorsByType request DiscoverySelector)]
-    (loop [result []
-           head (first selectors)
-           tail (rest selectors)]
-      (let [candidates (try-select listener id head)]
-        (if (seq tail)
-          (recur (concat result candidates) (first tail) (rest tail))
-          (concat result candidates))))))
+    (reduce #(into %1 (try-select listener id %2)) [] selectors)))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;; Discovery Descriptor Support