Small fix for equiv and equals #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are test cases added that fail without these changes. (= ordered-map some-record-with-same-keys) returns true without these changes, for example, whereas Clojure's built-in maps are never = to any record, by design, since records are distinct types. (.equals ordered-map something-else) currently uses = to compare corresponding values in the maps, but other Clojure persistent maps use .equals to compare corresponding values.
jafingerhut
added a commit
to jafingerhut/thalia
that referenced
this pull request
May 9, 2018
These tests have found small to medium issues with = and/or hash in several Clojure collection libraries I have tested. I have filed issues and suggested patches to fix these issues. data.avl 0.0.17 - https://dev.clojure.org/jira/browse/DAVL-10 data.int-map 0.2.4 - https://dev.clojure.org/jira/browse/DIMAP-16 data.priority-map 0.0.9 - https://dev.clojure.org/jira/browse/DPRIMAP-12 org.flatland/ordered 1.5.6 - clj-commons/ordered#34
|
Closing this PR in favor of #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.