-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes issue #19 #23
base: develop
Are you sure you want to change the base?
closes issue #19 #23
Conversation
Hi @grassesi , many thanks for getting started at this. I just tried to run the changes and I get a long list of errors like this: --- Logging error --- Is there a specific python version of package that is required? |
Hi @clessig, it should be fixed now. |
btw currently all logging output is directed towards |
00ce96c
to
e773fd4
Compare
import logger as it is setup in
utils.logger
module and useslogger.info()
where everprint
is used.Commented out prints were converted into
logger.debug()
. Also imports unused imports were removed throughout. Forcore.train.py
,core.train_multi.py
andcore.evaluator.py
the convention to import only modules was enforced for imports fromutils.utils
. closes #19 .