-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically set dns service address #618
Conversation
✅ Deploy Preview for kamaji-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey, thanks a lot for this fix. |
Are you sure the
Ok, maybe I'm getting your point: in IPv4 we can expect a +10 bit in the last octet, and +16 in IPv6? |
Whoopsie, I fucked up the example. 2001:db8:abcd::/64 is correct. The other one also has host bits set, which is not correct. I guess so, they specify :10 as DNS address, which is 16 bits added to the network address. |
c174e96
to
d71ccf7
Compare
Thanks, I added the required changes, such as:
I updated the initial comment on the issue just for reference. |
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
Signed-off-by: Dario Tranchitella <[email protected]>
d71ccf7
to
e1245d4
Compare
Closes #468, pinging the main stakeholder such as @kvaps and the IPv6 gurus @johannwagner @hexchen
When defining a different Service CIDR and an empty DNS Service one, Kamaji will automatically compute the correct value.
Once applying this Tenant Control Plane snippet:
This is the resulting one stored in the cluster.
Tested also with IPv6:
Defaulted values: