Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and chapters #48

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

va-an
Copy link
Contributor

@va-an va-an commented Mar 10, 2024

Hello!
I've updated the tests and related book chapters for working with clarinet-sdk and vistest for projects:

  • counter
  • multisig-vault
  • timelocked-wallet

I haven't finished with tiny-market yet, and suggest starting the review now because there are already quite a lot of changes.

I based my work on #42 and #44, where significant work on the tests was done, but those PRs don't seem active, and no changes were made to the text of the book itself - I plan to transfer the developments from these PRs here and complete them as part of this task.

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clarity-book ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 9:51am

@friedger
Copy link
Contributor

This PR looks more complete than #44

@va-an
Copy link
Contributor Author

va-an commented May 1, 2024

This PR looks more complete than #44

Yes, that's the reason I offered to close #44 (and also #42). I based this PR on work that was done in those PRs, and it looks like we can close them for simplicity.

I am sorry that I haven't finished this PR yet. I hope I can find more time for this soon.


const accounts = simnet.getAccounts();

test('get-count returns u0 for principals that never called count-up before', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of test is to write an english sentence like "test('if get-count returns u0 for principals that never called count-up before",.."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants