Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Banner Alert #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arorayash
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Apr 26, 2020

Deploy preview for knit-ui ready!

Built with commit 520b89f

https://deploy-preview-183--knit-ui.netlify.app

@arorayash arorayash requested a review from anshumanv April 27, 2020 03:22
@arorayash
Copy link
Contributor Author

@anshumanv Reminder for review.

@anshumanv
Copy link
Contributor

Oops my bad, on it. 👍

Copy link
Contributor

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test for this too?

import { BannerAlertWrapper } from "./StyledAlert"

const BannerAlert = (props: BannerAlertProps) => {
const alertMountNode = document.createElement("div")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a new node in the document, can we instead use the application root node?

This node will otherwise keep lying in the DOM unused, and more will be created everytime we render this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or make it configurable to use a mount node, we can supply mount node form the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants