Add and use the registerIcon and useIcon utils
#17755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
changed the title
registerIcon and useIcon utils
filipsobol
commented
Jan 15, 2025
| const POSSIBLE_INSERTION_POSITIONS = [ 'before', 'after' ] as const; | ||
|
|
||
| // Do the SVG parsing once and then clone the result <svg> DOM element for each new button. | ||
| const RETURN_ARROW_ICON_ELEMENT = new DOMParser().parseFromString( IconReturnArrow, 'image/svg+xml' ).firstChild!; |
There was a problem hiding this comment.
How much this change can affect performance?
filipsobol
commented
Jan 21, 2025
| import { MenuBarMenuListItemButtonView, ButtonView } from 'ckeditor5/src/ui.js'; | ||
| import { getButtonCreator } from '../utils.js'; | ||
|
|
||
| const ITALIC = 'italic'; | ||
| const italicIcon = /* #__PURE__ */ registerIcon( 'utalic', IconItalic ); |
There was a problem hiding this comment.
Suggested change
| const italicIcon = /* #__PURE__ */ registerIcon( 'utalic', IconItalic ); | |
| const italicIcon = /* #__PURE__ */ registerIcon( 'italic', IconItalic ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (core): Add a new
iconsconfiguration option to the editor. Related to #16546.Feature (utils): Add
registerIconanduseIconhelpers for registering and using customizable icons. Related to #16546.Feature: Use
registerIconanduseIconhelpers in all packages.Additional information
This is a follow-up to #17750.