-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the version checks to changelog tasks #1019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
force-pushed
the
i/3828-restartable-release
branch
from
October 8, 2024 05:47
fccb8bf
to
390762f
Compare
pomek
force-pushed
the
i/3828-restartable-release
branch
from
October 8, 2024 06:47
390762f
to
6e47a6d
Compare
pomek
added a commit
to ckeditor/ckeditor5-react
that referenced
this pull request
Oct 9, 2024
pomek
added a commit
to ckeditor/ckeditor5-angular
that referenced
this pull request
Oct 9, 2024
pomek
added a commit
to ckeditor/ckeditor5-vue
that referenced
this pull request
Oct 9, 2024
pomek
added a commit
to ckeditor/ckeditor5-integrations-common
that referenced
this pull request
Oct 9, 2024
pomek
added a commit
to ckeditor/ckeditor5-linters-config
that referenced
this pull request
Oct 9, 2024
This was referenced Oct 9, 2024
Merged
pomek
added a commit
to ckeditor/ckeditor5
that referenced
this pull request
Oct 9, 2024
…ified version is already created. Replaced git commands called from a shell with a library (simple-git).
psmyrek
previously approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
psmyrek
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
martnpaneq
approved these changes
Oct 10, 2024
pomek
added a commit
to ckeditor/ckeditor5-react
that referenced
this pull request
Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek
added a commit
to ckeditor/ckeditor5-angular
that referenced
this pull request
Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek
added a commit
to ckeditor/ckeditor5-vue
that referenced
this pull request
Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek
added a commit
to ckeditor/ckeditor5-linters-config
that referenced
this pull request
Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
pomek
added a commit
to ckeditor/ckeditor5-integrations-common
that referenced
this pull request
Oct 11, 2024
Internal: Aligned release scripts to recent changes in ckeditor5-dev (ckeditor/ckeditor5-dev#1019).
Dumluregn
pushed a commit
to ckeditor/ckeditor5
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (ci): Created a new binary script called
ckeditor5-dev-ci-is-workflow-restarted
that returns with a non-zero exit code if a given workflow is executed for the first time. The restarted workflows exit with a zero exit code.Feature (release-tools): A user-provided version will be checked against npm availability while generating a changelog. If it is already taken, the tools will not allow it to be used.
Other (release-tools): The
updateVersions()
task will no longer verify if the specifiedversion
is available on npm.Other (release-tools): The
publishPackages()
task filters out already published packages to avoid pushing the same archive twice. Thanks to that, it can be a part of a process that would be restarted.Other (release-tools): The
publishPackages()
task tries to publish the package once again when it fails independently from the returned error code. Previously, it was scheduled only when theE409
error occurred.Other (release-tools): The
verifyPackagesPublishedCorrectly()
task is no longer available as its responsibility has been merged into thepublishPackages()
task.Other (release-tools): The
commitAndTag()
task does not commit files if a tag for the specified version is already created.Closes cksource/ckeditor5-internal#3828.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.