Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npm shell commands with pacote #1018

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Replace npm shell commands with pacote #1018

merged 4 commits into from
Oct 7, 2024

Conversation

pomek
Copy link
Member

@pomek pomek commented Oct 7, 2024

Suggested merge commit message (convention)

Other (release-tools): We do not spawn an npm process to download a package manifest from the npm registry. Instead, we send an HTTP request using the pacote package. Closes ckeditor/ckeditor5#17191.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@coveralls
Copy link

coveralls commented Oct 7, 2024

Coverage Status

coverage: 88.531% (-0.02%) from 88.551%
when pulling 4f5c7e8 on i/17191-pacote
into 4cc0ea6 on master.

@pomek pomek marked this pull request as ready for review October 7, 2024 08:20
@pomek pomek requested a review from psmyrek October 7, 2024 08:23
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@pomek pomek merged commit a155390 into master Oct 7, 2024
6 of 7 checks passed
@pomek pomek deleted the i/17191-pacote branch October 7, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The checkVersionAvailability() in ckeditor5-dev-release-tools does not work on Windows
3 participants