Merge pull request #1015 from ckeditor/ck/17025

Fix (release-tools): Passing an odd number as a value of the `concurrency` option will not crash the `executeInParallel()` function. Closes ckeditor/ckeditor5#17025.

packages/ckeditor5-dev-release-tools/lib/utils/executeinparallel.js

@@ -48,6 +48,7 @@ export default async function executeInParallel( options ) {
 		concurrency = os.cpus().length / 2
 	} = options;
 
+	const concurrencyAsInteger = Math.floor( concurrency ) || 1;
 	const normalizedCwd = upath.toUnix( cwd );
 	const packages = ( await glob( `${ packagesDirectory }/*/`, {
 		cwd: normalizedCwd,
@@ -58,7 +59,7 @@ export default async function executeInParallel( options ) {
 		packages.filter( packagesDirectoryFilter ) :
 		packages;
 
-	const packagesInThreads = getPackagesGroupedByThreads( packagesToProcess, concurrency );
+	const packagesInThreads = getPackagesGroupedByThreads( packagesToProcess, concurrencyAsInteger );
 
 	const callbackModule = upath.join( cwd, crypto.randomUUID() + '.mjs' );
 	await fs.writeFile( callbackModule, `export default ${ taskToExecute };`, 'utf-8' );

packages/ckeditor5-dev-release-tools/tests/utils/executeinparallel.js

@@ -8,6 +8,7 @@ import { glob } from 'glob';
 import fs from 'fs/promises';
 import { registerAbortController, deregisterAbortController } from '../../lib/utils/abortcontroller.js';
 import executeInParallel from '../../lib/utils/executeinparallel.js';
+import os from 'os';
 
 const stubs = vi.hoisted( () => ( {
 	WorkerMock: class {
@@ -334,6 +335,58 @@ describe( 'executeInParallel()', () => {
 		await promise;
 	} );
 
+	it( 'should use number of cores divided by two as default (`concurrency`)', async () => {
+		vi.mocked( os.cpus ).mockReturnValue( new Array( 7 ) );
+
+		const promise = executeInParallel( defaultOptions );
+		await delay( 0 );
+
+		expect( stubs.WorkerMock.instances ).toHaveLength( 3 );
+
+		// Workers did not emit an error.
+		for ( const worker of stubs.WorkerMock.instances ) {
+			getExitCallback( worker )( 0 );
+		}
+
+		await promise;
+	} );
+
+	it( 'should round down to the closest integer (`concurrency`)', async () => {
+		const options = Object.assign( {}, defaultOptions, {
+			concurrency: 3.5
+		} );
+
+		const promise = executeInParallel( options );
+		await delay( 0 );
+
+		expect( stubs.WorkerMock.instances ).toHaveLength( 3 );
+
+		// Workers did not emit an error.
+		for ( const worker of stubs.WorkerMock.instances ) {
+			getExitCallback( worker )( 0 );
+		}
+
+		await promise;
+	} );
+
+	it( 'should assign at least one thread even if concurrency is 0 (`concurrency`)', async () => {
+		const options = Object.assign( {}, defaultOptions, {
+			concurrency: 0
+		} );
+
+		const promise = executeInParallel( options );
+		await delay( 0 );
+
+		expect( stubs.WorkerMock.instances ).toHaveLength( 1 );
+
+		// Workers did not emit an error.
+		for ( const worker of stubs.WorkerMock.instances ) {
+			getExitCallback( worker )( 0 );
+		}
+
+		await promise;
+	} );
+
 	it( 'should resolve the promise if a worker finished (aborted) with a non-zero exit code (first worker)', async () => {
 		const promise = executeInParallel( defaultOptions );
 		await delay( 0 );