Skip to content

Commit

Permalink
[chore](workflows) Disable PCH in GitHub workflows by default (apache…
Browse files Browse the repository at this point in the history
…#19447)

PCH slows the BE UT workflows down. Disable it by default in workflows.
  • Loading branch information
adonis0147 authored May 9, 2023
1 parent 096aa25 commit f8eb082
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/be-ut-clang.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@ jobs:
popd
export PATH="${DEFAULT_DIR}/ldb-toolchain/bin/:$(pwd)/thirdparty/installed/bin/:${PATH}"
DORIS_TOOLCHAIN=clang ./run-be-ut.sh -j "$(nproc)" --run --clean
DORIS_TOOLCHAIN=clang ENABLE_PCH=OFF ./run-be-ut.sh -j "$(nproc)" --run --clean
3 changes: 1 addition & 2 deletions .github/workflows/be-ut-mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,5 +95,4 @@ jobs:
tar -xvf doris-thirdparty-prebuilt-darwin-x86_64.tar.xz
popd
./run-be-ut.sh --run -j "$(nproc)" --clean
ENABLE_PCH=OFF ./run-be-ut.sh --run -j "$(nproc)" --clean
2 changes: 1 addition & 1 deletion run-be-ut.sh
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export UDF_RUNTIME_DIR="${DORIS_HOME}/lib/udf-runtime"
export LOG_DIR="${DORIS_HOME}/log"
while read -r variable; do
eval "export ${variable}"
done < <(sed 's/ //g' "${DORIS_HOME}/conf/be.conf" | grep -E "^[[:upper:]]([[:upper:]]|_|[[:digit:]])*=")
done < <(sed 's/[[:space:]]*\(=\)[[:space:]]*/\1/' "${DORIS_HOME}/conf/be.conf" | grep -E "^[[:upper:]]([[:upper:]]|_|[[:digit:]])*=")

mkdir -p "${LOG_DIR}"
mkdir -p "${UDF_RUNTIME_DIR}"
Expand Down

0 comments on commit f8eb082

Please sign in to comment.