This repository has been archived by the owner on Aug 29, 2020. It is now read-only.
Adding Network speed in bits per second - issue #57 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbassi
suggested changes
Apr 22, 2020
| ), | ||
| if self.show_bits { | ||
| format!( | ||
| "Rx/s: {} bits/s", |
There was a problem hiding this comment.
Everything looks good except we need the 'bits' label to change to 'Kb', 'Mb', etc as the amount grows. Maybe there's a rust library that can do this for us or we can write our own function to do this.
There was a problem hiding this comment.
We are currently using https://github.com/neosmart/prettysize-rs to do this for the bytes. I don't know if it works for bits, if there's another library that does, or if we should make a pull request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.