Add Logv(), a va_list variant of Log() function. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjappl
previously approved these changes
Oct 4, 2024
|
Thanks for the contribution, great catch. I'll submit as long as tests pass |
|
(will you fix the tests, and possibly add a new one, and then I'll submit this?) Thanks again for the contribution |
|
Oops, my bad...! I just added a fix commit. |
|
Let me check the existing tests so that I can add some. |
|
I'm going to merge this, and you can follow on with a test PR if you want. I would recommend it, if you have time, but I understand you might be busy! Thanks again for seeing a problem, reporting it, then fixing the issue, very much appreciated. Any additional contributions welcome. |
|
I was a bit late ;-) I just created another PR for it anyway. Please have a look. Thanks! |
cjappl
pushed a commit
that referenced
this pull request
Oct 4, 2024
A leftover task from #12 - add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11 .