Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display custom fields on Price Field Values #31839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Jan 20, 2025

Overview

Show Custom Fields on Price Field Values on the Edit Price Option page

Before

Price Field Value custom fields are not shown.

After

Price Field Value custom fields are shown on the Edit Price Option page.

Technical Details

Follows a similar pattern to #31487

Comments

This PR does not enable custom fields on Price Field Values since those are unlikely to be commonly needed. Extensions wanting to enable this can do so by editing the option group 'cg_extend_objects' similar to this or using API Explorer as below:

To test this:

  • enable Custom Fields on PriceFieldValues - can do this via API Explorer4:
    • entity: OptionValue
    • action: create
    • values: label: "Price Field Value", value: "PriceFieldValue", name: "price_field_value"
  • create Custom Field Group "used for" "Price Field Value"
  • add some custom fields
  • go to Manage Price Sets and create a new Price Set, doesn't matter what it is used for
  • create a Price Field with a type that uses options (ie Select, Radio or CheckBox)
  • add some option values
  • click 'Edit Price Options'
  • for an option, click 'Edit Option'
  • your custom fields should be shown ... !!
  • make changes, save, reopen to confirm changes have been saved
  • try adding a new option - your custom fields should be shown and saved

These custom fields are not shown elsewhere - they are intended for use by extensions.

Copy link

civibot bot commented Jan 20, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant