Fix PG community merge tests (pgmerge) #7778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ae3ed7d)
tejeswarm
force-pushed
the
fix-pgmerge
branch
4 times, most recently
from
3cef7d3 to
1fee9e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## naisila/pg17_support #7778 +/- ##
========================================================
- Coverage 89.61% 89.61% -0.01%
========================================================
Files 274 274
Lines 59689 59697 +8
Branches 7445 7448 +3
========================================================
+ Hits 53493 53499 +6
- Misses 4064 4069 +5
+ Partials 2132 2129 -3 |
tejeswarm
force-pushed
the
fix-pgmerge
branch
3 times, most recently
from
97115bf to
ce104fa
Compare
pgmerge.sql: This is a clone of the PostgreSQL community's merge.sql test, adapted for Citus by converting tables into Citus local tables. The expectation is that any MERGE syntax that works on PostgreSQL should work on Citus as-is, utilizing our MERGE deparser. Diffs, which primarily seem to stem fromtwo major features in MERGE introduced by the community: RETURNING support for MERGE MERGE support for updatable views Currently, Citus code does not support these features. For now, I have implemented changes to catch these cases and raise clean exceptions. With these adjustments, the pgmerge tests now pass without diffs.
tejeswarm
force-pushed
the
fix-pgmerge
branch
from
ce104fa to
29858d7
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
5 times, most recently
from
1e55f40 to
1c39f95
Compare
naisila
force-pushed
the
naisila/pg17_support
branch
14 times, most recently
from
3d6c111 to
83e7371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgmerge.sql:
This is a clone of the PostgreSQL community's merge.sql test, adapted for Citus by converting tables into Citus local tables. The expectation is that any MERGE syntax that works on PostgreSQL should work on Citus as-is, utilizing our MERGE deparser.
Diffs, which primarily seem to stem from two major features in MERGE introduced by the community:
RETURNING support for MERGE
MERGE support for updatable views
Currently, Citus code does not support these features. For now, I have implemented changes to catch these cases and raise clean exceptions. With these adjustments, the pgmerge tests now pass without diffs.