-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up cutscene doc mess ups #749
base: master
Are you sure you want to change the base?
Conversation
d965d62
to
c3da8bc
Compare
Also, statements inferred from decompiled scripts, e.g., "Only referenced in script [X]", "Always false", "Usually [X]", or "i.e., Michael Lamar ..." should probably be removed or left in the comments section where the garbage from past imports live. These descriptions are often misleading and barely contribute to describing what those parameters actually are. Ideally, the "what it is" would be supplemented by "how it is used". Unrelated comment: |
@stannum-cfx This should be good now, added draft in the miniscule chance someone came by while I was trying to commit :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most things look good, only the hash change has me slightly concerned and is something I can't verify.
@@ -5,7 +5,7 @@ aliases: ['0x971D7B15BCDBEF99'] | |||
## _GET_CUTSCENE_END_TIME | |||
|
|||
```c | |||
// 0x011883f41211432a | |||
// 0x971D7B15BCDBEF99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this will work properly, this might break stuff. @blattersturm could you verify this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what my actions were prior when I first made the mistake so that change was based on Gottfried's response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is already "broken" with the way it currently because it will always return 0 due to sanitation, swapping this shouldn't break compatibility with anything.
This also didn't manage to overwrite the original native definition with an int
return type so it shouldn't break C# codegen, we would just have to make sure that the native that was supposed to be in the enum slot gets named.
35aec43
to
91f5d48
Compare
c334a33
to
573ad81
Compare
This fixes a incorrect link to another native and an uncompleted sentence
I did see e80e64b#r72290446 however i am not sure the meaning of this, or the resolution. @gottfriedleibniz