Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ped): add further documentation for SET_ENABLE_HANDCUFFS #1188

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

MadsLeander
Copy link
Contributor

Adds further documentation for SET_ENABLE_HANDCUFFS and what it does.

Note: The example might be a little long, but I sincerely believe it's better than the following, as it showcases the native in an actual use case.

-- Sets handcuffs on the player's ped
SetEnableHandcuffs(PlayerPedId(), true)

If requested, I can make a short video showing/proving the example and my findings; I'm just too lazy to do it this second. Let me know if anything needs to be changed.

@AvarianKnight AvarianKnight self-assigned this Sep 10, 2024
Copy link
Contributor

@JayPaulinCodes JayPaulinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this very much, my only suggestion would be to maybe explore some code comments for the example, seeing as it's a bit more than just the native call and instead is an actual use case, it may be beneficial to add some code comments to help explain exactly what the example is achieving with the native in question.

Other than that 2 cents of mine, all looks good to me.

@AvarianKnight AvarianKnight added the needs validation This looks good, but needs additional confirmation of suggested change. label Sep 11, 2024
@AvarianKnight AvarianKnight added ready-to-merge and removed needs validation This looks good, but needs additional confirmation of suggested change. labels Oct 30, 2024
@AvarianKnight AvarianKnight merged commit 412baaa into citizenfx:master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants