Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian Trixie #164

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 13, 2023

🗣 Description

Add support for Debian Trixie. Also switch to using geerlingguy/docker-debian12-ansible now that it exists.

💭 Motivation and context

Debian Bookworm dropped in June, so we need to start testing on Trixie.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Oct 13, 2023
@jsf9k jsf9k marked this pull request as ready for review October 13, 2023 15:20
@jsf9k jsf9k requested a review from a team October 13, 2023 15:20
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖E 🎉

@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Oct 13, 2023
@mcdonnnj
Copy link
Member

@jsf9k ansible/ansible-lint#3841 has been merged and once a new version is cut (and our pre-commit configuration updated) we should be able to finish this pull request.

@jsf9k jsf9k force-pushed the improvement/debian-bookworm-released branch from 6bd8b32 to 6442bac Compare October 18, 2023 17:12
@jsf9k
Copy link
Member Author

jsf9k commented Oct 18, 2023

@jsf9k ansible/ansible-lint#3841 has been merged and once a new version is cut (and our pre-commit configuration updated) we should be able to finish this pull request.

A new version of ansible-lint has been released. I have uncommented Trixie in the metadata file and force pushed.

@jsf9k
Copy link
Member Author

jsf9k commented Oct 18, 2023

Well it worked on my local machine, but it didn't work here even after I blew away the cache. I guess I will try again in a day or so. 😢

@mcdonnnj
Copy link
Member

Well it worked on my local machine, but it didn't work here even after I blew away the cache. I guess I will try again in a day or so. 😢

@jsf9k The pre-commit hook version has to be bumped and I assume you're not doing that in this PR as it should trickle down from cisagov/skeleton-generic. Please see https://github.com/cisagov/skeleton-ansible-role/actions/runs/6565455910 for an Action run with the new hook version in effect however.

cisagovbot pushed a commit that referenced this pull request Mar 6, 2024
…upport_terraform-docs

Add ATX Header Support for `terraform-docs`
jsf9k and others added 2 commits March 27, 2024 04:50
Now that geerlingguy/docker-debian12-ansible is available we can switch
to it instead of using ours.
@mcdonnnj mcdonnnj force-pushed the improvement/debian-bookworm-released branch from 6442bac to fb16c79 Compare March 27, 2024 08:53
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit 387a5e9 Mar 27, 2024
15 checks passed
@mcdonnnj mcdonnnj deleted the improvement/debian-bookworm-released branch March 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Development

Successfully merging this pull request may close these issues.

4 participants