Fix HTTPS watermark #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkause
requested review from
dav3r,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
jsf9k
requested changes
Nov 17, 2023
output/artifacts/reporting/pshtt_reports/cyhy-USCCR-2023-11-17-https-report.pdf
Outdated
Show resolved
Hide resolved
jsf9k
added
bug
|
We will want a version bump for these changes as well. |
Moving the watermark information from the file header to the Table of Contents, reduces the opacity of the watermark from 100% to 10%. Followed the changes from cisagov/trustymail_reporter#54.
jeffkause
force-pushed
the
HTTPS-watermark-Update
branch
from
08ea9cf
to
4c40316
Compare
jsf9k
approved these changes
Nov 17, 2023
|
I updated production to use the Docker image from release 1.2.14 in production. That is the version that will get used in next weekend's BOD 18-01 scanning run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Lighten CISA watermark behind the report pages.
💭 Motivation and context
Fixes dark watermark issue in the HTTPS report Table of Contents.
🧪 Testing
Ran test report to verify the CISA watermark is transparent and the words on the pages can be read.
✅ Pre-approval checklist
in code comments.
✅ Post-merge checklist