-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cyhy-cvesync Lambda #25
Open
dav3r
wants to merge
47
commits into
develop
Choose a base branch
from
improvement/add-cyhy-cvesync-lambda
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+739
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav3r
added
the
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
label
Nov 5, 2024
jsf9k
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but please see my one question.
jsf9k
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I snuck in another question!
This instance will be used to test access to the DocumentDB database. It may be deleted later.
… to scheduling it to run every X minutes. This allows for more flexibility in scheduling.
This is to prevent unintentional committing of the SSH credentials created in this repo.
The Lambda no longer requires any event input; it just runs and does it's thang.
…logs for the kevsync Lambda
Also includes an updated variable description to satisfy the markdownlint pre-commit hook.
Co-authored-by: Shane Frasier <[email protected]>
Co-authored-by: Shane Frasier <[email protected]>
Co-authored-by: Shane Frasier <[email protected]>
… kevsync lambda module This allows Terraform to determine if a new version of the lambda deployment package is present in the bucket and if so, update the lambda function to use it.
We don't need them here and Terraform constantly wanted to add them on every apply, even when they were already present.
Invoke it once upon deployment to initially load CVE data into the database. Then, schedule it to run on a regular basis thereafter.
Co-authored-by: Shane Frasier <[email protected]>
Co-authored-by: Shane Frasier <[email protected]>
dav3r
force-pushed
the
improvement/add-cyhy-cvesync-lambda
branch
from
November 15, 2024 16:43
e2ec4db
to
61b7c0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the cyhy-cvesync-lambda. It is invoked when this code is initially applied, in order to populate the CVE collection in the database. It is also scheduled to run regularly, in order to keep up-to-date with CVE data.
Note that this PR is built on top of #12. For clarity, these are the commits that are specific and relevant to this PR:
💭 Motivation and context
The CyHy database should always include up-to-date CVE information in order to function correctly.
🧪 Testing
I applied these changes in a development environment and verified that the initial Lambda ran successfully against a database with no previously-loaded CVEs. I also confirmed that the Lambda ran successfully on the schedule that I selected.
✅ Pre-approval checklist
to reflect the changes in this PR.