Add the report UUID to the ScubaResults.json filename #1426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add the report UUID to the ScubaResults.json filename.
💭 Motivation and context
Ensures each results file has a unique file name. Closes #1422.
🧪 Testing
Invoke-Scuba
, works as expectedInvoke-ScubaCached
, works as expectedInvoke-ScubaCached
where the input folder has one file matching "ScubaResults*.json", "ScubaResults.json", works as expectedInvoke-ScubaCached
where the input folder has one file matching "ScubaResults*.json", "ScubaResults_{uuid}.json", works as expectedInvoke-ScubaCached
where the input folder has two file matching "ScubaResults*.json", the most recently created file is used, as expectedInvoke-Scuba
andInvoke-ScubaCached
with a non-defaultOutPath
parameterInvoke-Scuba
andInvoke-ScubaCached
with a non-defaultOutJsonFileName
parameter✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist