added CI

.github/workflows/continuous-integration.yml

@@ -0,0 +1,25 @@
+name: PennLFG CI
+
+on:
+  pull_request:
+    branches: [ master ]
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  lint-test-build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Use Node.js 21
+        uses: actions/setup-node@v3
+        with:
+          node-version: 21
+      - run: npm install
+      - run: npm test
+      - run: npm run lint
+      - run: npm run build --if-present

coverage/clover.xml

@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<coverage generated="1713117562844" clover="3.2.0">
-  <project timestamp="1713117562844" name="All files">
-    <metrics statements="142" coveredstatements="99" conditionals="24" coveredconditionals="17" methods="17" coveredmethods="11" elements="183" coveredelements="127" complexity="0" loc="142" ncloc="142" packages="4" files="5" classes="5"/>
+<coverage generated="1713120471157" clover="3.2.0">
+  <project timestamp="1713120471157" name="All files">
+    <metrics statements="142" coveredstatements="99" conditionals="26" coveredconditionals="19" methods="17" coveredmethods="11" elements="185" coveredelements="129" complexity="0" loc="142" ncloc="142" packages="4" files="5" classes="5"/>
     <package name="src.controller">
-      <metrics statements="43" coveredstatements="37" conditionals="14" coveredconditionals="14" methods="2" coveredmethods="2"/>
+      <metrics statements="43" coveredstatements="37" conditionals="16" coveredconditionals="16" methods="2" coveredmethods="2"/>
       <file name="server.js" path="/Users/alainwelliver/Documents/code-projects/penn-course-projects/sophomore-spring/cis350/Team-8-alain-sem-adam-abhinav-gabe/src/controller/server.js">
-        <metrics statements="43" coveredstatements="37" conditionals="14" coveredconditionals="14" methods="2" coveredmethods="2"/>
+        <metrics statements="43" coveredstatements="37" conditionals="16" coveredconditionals="16" methods="2" coveredmethods="2"/>
         <line num="1" count="2" type="stmt"/>
         <line num="2" count="2" type="stmt"/>
         <line num="3" count="2" type="stmt"/>
@@ -16,7 +16,7 @@
         <line num="11" count="2" type="stmt"/>
         <line num="14" count="2" type="stmt"/>
         <line num="17" count="4" type="stmt"/>
-        <line num="20" count="4" type="cond" truecount="4" falsecount="0"/>
+        <line num="20" count="4" type="cond" truecount="6" falsecount="0"/>
         <line num="21" count="1" type="stmt"/>
         <line num="25" count="3" type="stmt"/>
         <line num="26" count="3" type="stmt"/>

coverage/lcov-report/index.html

@@ -30,9 +30,9 @@ <h1>All files</h1>
 
 
             <div class='fl pad1y space-right2'>
-                <span class="strong">70.83% </span>
+                <span class="strong">73.07% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>17/24</span>
+                <span class='fraction'>19/26</span>
             </div>
 
 
@@ -86,7 +86,7 @@ <h1>All files</h1>
 	<td data-value="86.04" class="pct high">86.04%</td>
 	<td data-value="43" class="abs high">37/43</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="14" class="abs high">14/14</td>
+	<td data-value="16" class="abs high">16/16</td>
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="2" class="abs high">2/2</td>
 	<td data-value="86.04" class="pct high">86.04%</td>
@@ -146,7 +146,7 @@ <h1>All files</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="prettify.js"></script>
         <script>

coverage/lcov-report/src/controller/controllerUtils/index.html

@@ -101,7 +101,7 @@ <h1><a href="../../../index.html">All files</a> src/controller/controllerUtils</
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../../prettify.js"></script>
         <script>

coverage/lcov-report/src/controller/controllerUtils/jwtAuth.js.html

@@ -262,7 +262,7 @@ <h1><a href="../../../index.html">All files</a> / <a href="index.html">src/contr
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../../prettify.js"></script>
         <script>

coverage/lcov-report/src/controller/index.html

@@ -32,7 +32,7 @@ <h1><a href="../../index.html">All files</a> src/controller</h1>
             <div class='fl pad1y space-right2'>
                 <span class="strong">100% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>14/14</span>
+                <span class='fraction'>16/16</span>
             </div>
 
 
@@ -86,7 +86,7 @@ <h1><a href="../../index.html">All files</a> src/controller</h1>
 	<td data-value="86.04" class="pct high">86.04%</td>
 	<td data-value="43" class="abs high">37/43</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="14" class="abs high">14/14</td>
+	<td data-value="16" class="abs high">16/16</td>
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="2" class="abs high">2/2</td>
 	<td data-value="86.04" class="pct high">86.04%</td>
@@ -101,7 +101,7 @@ <h1><a href="../../index.html">All files</a> src/controller</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../prettify.js"></script>
         <script>

coverage/lcov-report/src/controller/server.js.html

@@ -32,7 +32,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/controll
             <div class='fl pad1y space-right2'>
                 <span class="strong">100% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>14/14</span>
+                <span class='fraction'>16/16</span>
             </div>
 
 
@@ -266,8 +266,8 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/controll
   const { username, password, fname, lname } = req.body;
 &nbsp;
   // check if username and password were inputted
-  if (!username || !password) {
-    return res.status(400).json({ error: 'Username and password are required' });
+  if (!username || !password || !fname || !lname) {
+    return res.status(400).json({ error: 'Username, password, first name, and last name are required' });
   }
 &nbsp;
   // query the database to see if the username already exists
@@ -346,7 +346,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/controll
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../prettify.js"></script>
         <script>

coverage/lcov-report/src/model/dbUtils.js.html

@@ -223,7 +223,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/model</a
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../prettify.js"></script>
         <script>

coverage/lcov-report/src/model/index.html

@@ -116,7 +116,7 @@ <h1><a href="../../index.html">All files</a> src/model</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../prettify.js"></script>
         <script>

coverage/lcov-report/src/model/users.js.html

@@ -376,7 +376,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">src/model</a
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../../prettify.js"></script>
         <script>

coverage/lcov-report/test/index.html

@@ -101,7 +101,7 @@ <h1><a href="../index.html">All files</a> test</h1>
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../prettify.js"></script>
         <script>

coverage/lcov-report/test/testUtils.js.html

@@ -247,7 +247,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">test</a> testUt
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at 2024-04-14T17:59:22.830Z
+                at 2024-04-14T18:47:51.141Z
             </div>
         <script src="../prettify.js"></script>
         <script>

coverage/lcov.info

@@ -55,6 +55,8 @@ BRDA:20,0,0,1
 BRDA:20,0,1,3
 BRDA:20,1,0,4
 BRDA:20,1,1,3
+BRDA:20,1,2,3
+BRDA:20,1,3,3
 BRDA:28,2,0,1
 BRDA:28,2,1,2
 BRDA:58,3,0,1
@@ -65,8 +67,8 @@ BRDA:66,5,0,1
 BRDA:66,5,1,2
 BRDA:80,6,0,1
 BRDA:80,6,1,1
-BRF:14
-BRH:14
+BRF:16
+BRH:16
 end_of_record
 TN:
 SF:src/controller/controllerUtils/jwtAuth.js

src/controller/server.js

@@ -17,8 +17,8 @@ app.post('/register', async (req, res) => {
   const { username, password, fname, lname } = req.body;
 
   // check if username and password were inputted
-  if (!username || !password) {
-    return res.status(400).json({ error: 'Username and password are required' });
+  if (!username || !password || !fname || !lname) {
+    return res.status(400).json({ error: 'Username, password, first name, and last name are required' });
   }
 
   // query the database to see if the username already exists

test/server.test.js

@@ -44,7 +44,7 @@ describe("API endpoint testing", () => {
         .expect(400);
     });
 
-    it("should fail with 409 if username already exists", async () => {
+    it("should fail with 401 if username already exists", async () => {
       // Assuming the user from the first test already exists
       const response = await request(app)
         .post('/register')