Build images in GitHub Actions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR TODOs
|
This comment has been minimized.
This comment has been minimized.
|
I have validated all 3 images like this: 🚢 All are looking good! |
aanm
previously requested changes
May 25, 2020
|
@aanm thanks for the review! Using I've started squashing the commits already, will definitely squash a few more! |
|
@errordeveloper the following secrets and repositories were added / created: |
|
@aanm could you please create |
|
created |
- add APL 2
- add Makefile
- add GitHub Actions workflows
- build and push new images on commits to master
- check dockerfile and shell scripts with hadolint and shellcheck
on pull-requests
- add image tag genrator script
- add `build-image.sh` to wrap conditional build logic, as handing exit
codes in a makefile is quite tedious, it's easier to use a script
- add maker image - it contains make, buildx and other core
dependencies required to run containerised builds independently
of what version of Docker daemon and client is avalaible
- include `docker-credential-env` to avoids having to store
passwords in `config.json` on disk, which usually happens
when `docker login` is ran without some sort of keychain
provider configured
- include shellcheck and hadolint
- add compilers, llvm, bpftool and iproute2 images
- remove old Dockerfiles
Signed-off-by: Ilya Dmitrichenko <[email protected]>
|
@aanm I've renamed all images and squashed the commits, please merge! |
Signed-off-by: Ilya Dmitrichenko <[email protected]>
aanm
approved these changes
May 26, 2020
borkmann
added a commit
that referenced
this pull request
May 28, 2020
Commit 61d38f6 ("Build images in GitHub Actions (#3)") pointed bpftool back to an old revision which breaks the expectations from cilium-runtime. Move it forward in time to something recent. Signed-off-by: Daniel Borkmann <[email protected]>
borkmann
added a commit
that referenced
this pull request
May 28, 2020
Commit 61d38f6 ("Build images in GitHub Actions (#3)") pointed bpftool back to an old revision which breaks the expectations from cilium-runtime. Move it forward in time to something recent. Signed-off-by: Daniel Borkmann <[email protected]>
errordeveloper
added a commit
to errordeveloper/cilium-image-tools
that referenced
this pull request
Jun 8, 2020
BPF bytecode is the target, it is independent of CPU architecture. The configuration was originally overlooked in cilium#3. Fixes: cilium#31 Signed-off-by: Ilya Dmitrichenko <[email protected]>
aanm
pushed a commit
that referenced
this pull request
Jun 8, 2020
BPF bytecode is the target, it is independent of CPU architecture. The configuration was originally overlooked in #3. Fixes: #31 Signed-off-by: Ilya Dmitrichenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
arm64buildxto create proper multiarch imagesFROMstatementsdocker login, which is insecure as it stores a token in plain textDockerfilesand shell script to detect issues earlyFollow-up features (will file issues):
FROMstatements with new digests - automate updatingFROMstatements with new digests #9