Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicluster: correctly specify the dst context to clustermes connect #2810

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

giorio94
Copy link
Member

Use the correct variable to specify the destination context for the clustermesh connect step, which is otherwise left empty:

cilium --context gke... clustermesh connect --destination-context ''

Although the workflow is currently working regardless (as the context referring to the second cluster is the default one), that no longer applies when pulling in the latest Cilium CLI changes, as --dst-context has been converted to possibly take a list of contexts.

Fixes: f2fba32 ("multicluster: Run cilium-cli inside a container")

Use the correct variable to specify the destination context for the
clustermesh connect step, which is otherwise left empty:

  cilium --context gke... clustermesh connect --destination-context ''

Although the workflow is currently working regardless (as the context
referring to the second cluster is the default one), that no longer
applies when pulling in the latest Cilium CLI changes, as --dst-context
has been converted to possibly take a list of contexts.

Fixes: f2fba32 ("multicluster: Run cilium-cli inside a container")
Signed-off-by: Marco Iorio <[email protected]>
@michi-covalent michi-covalent merged commit 2115e2c into main Sep 23, 2024
13 checks passed
@michi-covalent michi-covalent deleted the pr/giorio94/gha-multicluster-fix branch September 23, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants