Merge pull request autotest#5565 from Yingshun/up_link_state

virtual_network: Add a case of update-device

libvirt/tests/cfg/virtual_network/update_device/update_iface_link_state.cfg

@@ -0,0 +1,37 @@
+- virtual_network.update_device.iface_link_state:
+    type = update_iface_link_state
+    start_vm = no
+    timeout = 240
+    outside_ip = "www.redhat.com"
+    vm_ping_outside = pass
+    variants test_scenario:
+        - add:
+            updated_link_state = "down"
+        - delete:
+            initial_link_state = "down"
+            updated_link_state = 
+        - update:
+            initial_link_state = "down"
+            updated_link_state = "up"
+    variants model_type:
+        - virtio:
+        - e1000e:
+            only x86_64
+        - igb:
+            only x86_64
+            func_supported_since_libvirt_ver = (9, 3, 0)
+        - rtl8139:
+            only x86_64
+    variants interface_type:
+        - network:
+            iface_base_attrs = {"type_name": "network", "source": {"network": "default"}}
+        - direct:
+            only virtio
+            host_iface =
+            iface_base_attrs = {"type_name": "direct", "source": {"dev": host_iface, "mode": "bridge"}}
+        - ethernet:
+            only virtio
+            create_tap = "yes"
+            iface_base_attrs = {"type_name": "ethernet", "target": {"dev": tap_name, "managed": "no"}}
+
+    iface_attrs = {"model": "${model_type}", **${iface_base_attrs}}

libvirt/tests/src/virtual_network/update_device/update_iface_link_state.py

@@ -0,0 +1,110 @@
+from virttest import libvirt_version
+from virttest import virsh
+from virttest import utils_misc
+from virttest import utils_net
+
+from virttest.libvirt_xml import vm_xml
+from virttest.utils_libvirt import libvirt_vmxml
+from virttest.utils_test import libvirt
+
+from provider.interface import interface_base
+from provider.virtual_network import network_base
+
+VIRSH_ARGS = {"ignore_status": False, "debug": True}
+
+
+def run(test, params, env):
+    """
+    Test update-device for interface link state
+    """
+    libvirt_version.is_libvirt_feature_supported(params)
+
+    outside_ip = params.get("outside_ip")
+    host_iface = params.get("host_iface")
+    host_iface = host_iface if host_iface else utils_net.get_net_if(
+        state="UP")[0]
+    rand_id = utils_misc.generate_random_string(3)
+    bridge_name = "br_" + rand_id
+    tap_name = "tap_" + rand_id
+    interface_type = params.get("interface_type")
+    iface_attrs = eval(params.get("iface_attrs", "{}"))
+    initial_link_state = params.get("initial_link_state", "")
+    if initial_link_state:
+        iface_attrs.update({"link_state": initial_link_state})
+    test_states = [("yes", "up"), ("no", "down")]
+    if initial_link_state == "down":
+        test_states.reverse()
+    updated_link_state = params.get("updated_link_state")
+
+    vm_name = params.get("main_vm")
+    vm = env.get_vm(vm_name)
+
+    vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)
+    bkxml = vmxml.copy()
+
+    try:
+        if interface_type == "ethernet":
+            utils_net.create_linux_bridge_tmux(bridge_name, host_iface)
+            network_base.create_tap(tap_name, bridge_name, "root")
+
+        vmxml.del_device('interface', by_tag=True)
+        libvirt_vmxml.modify_vm_device(vmxml, 'interface', iface_attrs)
+        test.log.debug(f'VMXML of {vm_name}:\n{virsh.dumpxml(vm_name).stdout_text}')
+        vm.start()
+        session = vm.wait_for_serial_login()
+        vm_iface = interface_base.get_vm_iface(session)
+
+        test.log.info("TEST_STEP: Check the link state in vm.")
+        iflist = libvirt.get_interface_details(vm_name)
+        test.log.debug(f'iflist of vm: {iflist}')
+        iface_info = iflist[0]
+        iface_mac = iface_info['mac']
+        for exp_link_state, exp_domiflik_state in test_states:
+            if exp_link_state == test_states[-1][0]:
+                iface = vm_xml.VMXML.new_from_dumpxml(
+                    vm.name).devices.by_device_tag("interface")[0]
+                if updated_link_state:
+                    iface.setup_attrs(**{"link_state": updated_link_state})
+                else:
+                    iface.del_link_state()
+                test.log.debug(f"iface xml to be updated: {iface}")
+                test.log.info("TEST_STEP: Update interface device.")
+                virsh.update_device(vm_name, iface.xml, **VIRSH_ARGS)
+
+            link_info = virsh.domif_getlink(
+                vm_name, iface_mac, **VIRSH_ARGS).stdout_text
+            if exp_domiflik_state not in link_info:
+                test.fail("Failed to get expected interface link state '%s'!"
+                          % exp_domiflik_state)
+
+            if exp_link_state == "yes":
+                if exp_link_state == test_states[-1][0]:
+                    utils_net.restart_guest_network(session)
+                ips = {'outside_ip': outside_ip}
+                network_base.ping_check(params, ips, session, force_ipv4=True)
+
+            output = session.cmd_output("ethtool %s" % vm_iface)
+            test.log.debug(output)
+            if "Link detected: %s" % exp_link_state not in output:
+                test.fail("Failed to get expected link state '%s' in ethtool "
+                          "cmd!" % exp_link_state)
+        vm_iface = vm_xml.VMXML.new_from_dumpxml(vm.name)\
+            .devices.by_device_tag("interface")[0]
+
+        test.log.info("TEST_STEP: Check the live xml for the current link state.")
+        iface_attrs = vm_iface.fetch_attrs()
+        test.log.debug(f"iface attrs: {iface_attrs}")
+        if iface_attrs.get("link_state"):
+            if iface_attrs.get("link_state") != exp_domiflik_state:
+                test.fail("Failed to get expected link state '%s' in live xml."
+                          % exp_domiflik_state)
+        else:
+            if updated_link_state:
+                test.fail("There should be no link state in live xml.")
+        session.close()
+
+    finally:
+        bkxml.sync()
+        if interface_type == "ethernet":
+            network_base.delete_tap(tap_name)
+            utils_net.delete_linux_bridge_tmux(bridge_name, host_iface)