Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement terminal size warning #33

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Implement terminal size warning #33

merged 6 commits into from
Jan 30, 2025
+36 −13

Conversation

thezbm
Copy link
Contributor

@thezbm thezbm commented Jan 30, 2025 •
edited by chshersh
Loading

Closes #32

@chshersh chshersh self-requested a review January 30, 2025 08:50
@chshersh chshersh added type: feature New feature request component: UI Issues related to changing UI labels Jan 30, 2025
chshersh
chshersh requested changes Jan 30, 2025
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @thezbm!

Thanks for this QoL improvements! I left a few comments to improve the output a little bit but the general idea is exactly what I wanted 🙂

lib/tui/tui.ml Outdated Show resolved Hide resolved
lib/tui/tui.ml Outdated Show resolved Hide resolved
@thezbm thezbm requested a review from chshersh January 30, 2025 10:41
chshersh
chshersh approved these changes Jan 30, 2025
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you!

@chshersh chshersh merged commit 0eacb07 into chshersh:main Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@thezbm thezbm

Labels
component: UI Issues related to changing UI type: feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a warning about recommended terminal size
2 participants
@thezbm @chshersh