Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for copy pasting valid phone number #155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anees17861
Copy link

There is an issue of copying a valid phone number with country code. The code appends the selected country code resulting in invalid number. To solve this I've copied the content of set(phoneNumber) to didEditText().
It solves another issue where the selected country code doesn't match the code in pasted number

The code can be improved if set(phoneNumber) returns a boolean to wether it was a success. This helps improve client code as well since invalid numbers can then be handled better. Example use case is picking from contact picker with wrong number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant