fix for copy pasting valid phone number #155
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue of copying a valid phone number with country code. The code appends the selected country code resulting in invalid number. To solve this I've copied the content of
set(phoneNumber)
todidEditText()
.It solves another issue where the selected country code doesn't match the code in pasted number
The code can be improved if
set(phoneNumber)
returns a boolean to wether it was a success. This helps improve client code as well since invalid numbers can then be handled better. Example use case is picking from contact picker with wrong number