Online allocator switching #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvest
force-pushed
the
allocator-failover
branch
from
7daf17f
to
fc06e1f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/test/java/stormpot/tests/blackbox/AllocatorBasedPoolTest.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/stormpot/tests/blackbox/AllocatorBasedPoolTest.java
Dismissed
Show dismissed
Hide dismissed
src/test/java/stormpot/tests/blackbox/AllocatorBasedPoolTest.java
Dismissed
Show dismissed
Hide dismissed
This way, cancelled subscribers do not pile up on Completions. This is important for allocator switching, as their completions get bound to the shutdown completion, and they cancel their subscriptions when they complete. If their nodes cannot be reused, they would pile up over the lifetime of the pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #88