-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP request header support #48
base: next
Are you sure you want to change the base?
Conversation
I agree that this should be in there... please accept this so everyone can benefit! :-) |
👍 |
@ashmckenzie would you please submit a new PR in the new fork called Medusa?
|
👍 Sample:
|
@chriskite Can we merge this? |
The need is not . It is just information . |
@atgs-ghayakawa @paresharma could u help adapt this PR to a new PR in the new fork called Medusa? |
@brutuscat I can just use Medusa in place of Anemone with BAA. 👍 Medusa.crawl(url, { http_basic_authentication: [username, password] }) do |medusa|
medusa.on_every_page do |page|
puts page.code
end
end Now, that I am at it I'll do a general clean up and make it compatible with Ruby 2.2 (which would mean dropping support for Kyoto and Tokyo, I guess). Will do a PR when it's done. 😄 |
Hi,
I needed to add some additional HTTP request headers and didn't see any support for that currently. Happy to change anything / add more specs to cover the change.
Ash.