Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client changes required for chunked responses #30

Draft
wants to merge 3 commits into
base: caw/add-chunked-support
Choose a base branch
from

Conversation

fisherdarling
Copy link

@fisherdarling fisherdarling commented May 31, 2024

In this PR we:

  • prefix the final chunk with a zero to mark it as the last one.
  • streaming api for converting chunked hpke response bodies
  • streaming api for parsing indeterminate-length bhttp bodies. Note, this is missing indeterminate-length trailers conversion.

Todo:

  • Add indeterminate-length bhttp response parsing
  • Update tests to use the new streaming bhttp/hpke readers

I'm by no means an experienced go programmer. Any feedback is very much welcome!

@fisherdarling fisherdarling marked this pull request as draft May 31, 2024 17:17
@fisherdarling fisherdarling changed the title [DRAFT] client changes required for chunked responses client changes required for chunked responses May 31, 2024
@fisherdarling fisherdarling changed the base branch from main to caw/add-chunked-support May 31, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant