Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing FIREMinimizerIntegrator #420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hannahbrucemacdonald
Copy link
Contributor

Previously NaN check prevented the integrator from taking any uphill steps, when the correct protocol should allow for n_min consecutive uphill steps.

Relaxing test criteria (tolerance and max_iterations) as test was erroneously passing before as ^ was causing delta_t to decrease rapidly

@jaimergp
Copy link
Member

I just realized that jax-md provides a FIRE minimizer as well, so maybe we can also check against their implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants