Refactor to remove portions of code that are not used by Chocolatey (CU-ENGTASKS-616)

[corbob]

Description Of Changes

Remove code that is not being used in Chocolatey components

Motivation and Context

A line of code removed is a line of code debugged. As well as the need to ensure that we're testing the code as much as possible. Chocolatey can't test the code for sections we don't use.

Testing

This is how I have tested it... This is based upon my development layout where all git repositories are cloned into C:/code_local The below scripts don't care about that part, but they do care that every repository is within a single folder.

Clone all of the repositories:

This PowerShell script will do a shallow clone of every repository required save for the Rhino.Licensing repository (you must be authenticated to GitLab through https):

@(
'https://github.com/chocolatey/choco'
'https://gitlab.com/chocolatey/collaborators/choco-licensed'
'https://gitlab.com/chocolatey/licensing-administration/licensing-services'
'https://gitlab.com/chocolatey/licensing-administration/chocolatey-pro-server-simple'
'https://gitlab.com/chocolatey/central-management/choco-licensed-management-ui'
'https://gitlab.com/chocolatey/collaborators/choco-licensed-services'
'https://github.com/chocolatey/ChocolateyGUI'
'https://gitlab.com/chocolatey/collaborators/chocolateygui-licensed'
) | % { git clone $_ --depth=1 }

Clean Repositories

If you already have all of the repositories cloned down, as long as you're in the master/develop branch you can use this script to clean them all:

BEWARE: This script will delete any files not tracked by the repository, as well as all modified files tracked by the repository.

$repos = @(
    'choco'
    'choco-licensed'
    'license-generator'
    'licensing-services'
    'chocolatey-pro-server-simple'
    'choco-licensed-management-ui'
    'choco-licensed-services'
    'ChocolateyGUI'
    'chocolateygui-licensed'
)
foreach ( $repo in $repos ) {
    push-location ./$repo
    git clean -xdf
    git restore .
    Pop-Location
}

Build all of the things

In an administrative PowerShell terminal, run the script ./BuildAll.ps1. This will take upwards of an hour, and will build all components that depend on Rhino.Licensing providing their Chocolatey packages in C:\CodeDrops

Testing all the things

Now comes the actual testing of the things. The testing that I have undertaken up to this point is to build all the things mentioned above. I have also copied all of the packages from C:\CodeDrops to a Test Kitchen environment where I have ran the CCM Test kitchen against it with all of the tests.

I have also run choco install chocolateygui chocolateygui-licensed on that environment and ensured that GUI installs as expected. I am unable to launch GUI with a large message box regarding --allow-unofficial, but I believe that's related to the custom Chocolatey.Lib.

Change Types Made

• Bug fix (non-breaking change)
• Feature / Enhancement (non-breaking change)
• Breaking change (fix or feature that could cause existing functionality to change)
• PowerShell code changes.

Related Issue

Fixes #18

Change Checklist

• Requires a change to the documentation
• Documentation has been updated
• Tests to cover my changes, have been added
• All new and existing tests passed.
• PowerShell v2 compatibility checked.

[corbob]

I thought this was ready, but I did a spot check of the license files, and all of the expired ones were created with SHA1 (even though they claim to be not SHA1 😂 ). I'll add in the code used to create the files and add some notes to add them to the project in the next few days.

[choco-bot]

Task linked: ENGTASKS-616 Refactor Rhino Licensing to remove unused code and tests

[corbob]

@gep13 this should be ready for review now. The only issue I've encountered is that I can't launch GUI with my custom build of Chocolatey.lib.

[gep13]

There is a comment in line that I think we need to address, either to remove it, or add the other numbers. Happy to discuss.

[gep13]

LGTM!

[gep13]

@corbob thanks for getting all this pulled together! This will hopefully make the maintenance of this much easier going forward!