Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove portions of code that are not used by Chocolatey #18

Closed
corbob opened this issue Apr 27, 2022 · 0 comments · Fixed by #20
Closed

Remove portions of code that are not used by Chocolatey #18

corbob opened this issue Apr 27, 2022 · 0 comments · Fixed by #20
Labels
3 - Review BreakingChange
Milestone
2.0.0

Comments

@corbob
Copy link
Member

corbob commented Apr 27, 2022

Is Your Feature Request Related To A Problem? Please describe.

Remove portions of code that are not used by Chocolatey products

Describe The Solution. Why is it needed?

The upstream project is no longer being updated. Chocolatey still uses the product, but we don't use all of the features from upstream. To remove potential bugs, we should remove unused code.

Additional Context.

We should also work to ensure we have test coverage as much as possible.

Related Issues
corbob added a commit to corbob/rhino-licensing that referenced this issue May 10, 2022
@corbob
(chocolatey#18) Remove RemoveExistingLicense
7bd2ae2 
We don't use this function in Rhino.Licensing. Removing it.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 19, 2022
@corbob
(chocolatey#18) Remove RemoveExistingLicense
736e347 
We don't use this function in Rhino.Licensing. Removing it.
@corbob corbob mentioned this issue May 19, 2022
Merged
9 tasks
corbob added a commit to corbob/rhino-licensing that referenced this issue May 23, 2022
@corbob
(chocolatey#18) Remove more files not used
6edb456 
Remove a few more files from project/solution
corbob added a commit to corbob/rhino-licensing that referenced this issue May 24, 2022
@corbob
(chocolatey#18) Remove RemoveExistingLicense
5d1e4af 
We don't use this function in Rhino.Licensing. Removing it.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 24, 2022
@corbob
(chocolatey#18) Remove more files not used
9c43917 
Remove a few more files from project/solution
corbob added a commit to corbob/rhino-licensing that referenced this issue May 25, 2022
@corbob
(chocolatey#18) Remove licenses that are not used
d8bc2e7 
Remove the license types that Chocolatey doesn't use.

This includes Floating and Subscription licenses.
Removes validating with a server (subscription).
Also removes the license reassertion that's caused issues in the past.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 25, 2022
@corbob
(chocolatey#18) Update Chocolatey.Cake.Recipe version
23e9161 
Update to use the new Chocolatey.Cake.Recipe version.
Suppress creation of SolutionVersion.cs
Update Readme with current information about running tests.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 25, 2022
@corbob
(chocolatey#18) Revamp tests
0596e09 
Update tests to split out generation and validation.
Created xml files to verify aspects of generation and validation.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 25, 2022
@corbob
(chocolatey#18) Add script to build all dependent projects
14b5fa6 
Add a script that will build every project that  depend on Rhino.Licensing.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 26, 2022
@corbob
(chocolatey#18) Remove licenses that are not used
bdc5ffd 
Remove the license types that Chocolatey doesn't use.

This includes Floating and Subscription licenses.
Removes validating with a server (subscription).
Also removes the license reassertion that's caused issues in the past.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 26, 2022
@corbob
(chocolatey#18) Update Chocolatey.Cake.Recipe version
24e229f 
Update to use the new Chocolatey.Cake.Recipe version.
Suppress creation of SolutionVersion.cs
Update Readme with current information about running tests.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 26, 2022
@corbob
(chocolatey#18) Revamp tests
cb3e2b5 
Update tests to split out generation and validation.
Created xml files to verify aspects of generation and validation.
Updated readme with instructions to generate test license files.
corbob added a commit to corbob/rhino-licensing that referenced this issue May 26, 2022
@corbob
(chocolatey#18) Add script to build all dependent projects
4ab69ee 
Add a script that will build every project that  depend on Rhino.Licensing.
@corbob corbob added this to the 2.0.0 milestone Jun 29, 2022
corbob added a commit to corbob/rhino-licensing that referenced this issue Jul 12, 2022
@corbob
(chocolatey#18) Add test for mapping of LicenseType to int
8d37f45 
We use the int for the database, this ensures we don't accidentally
change that mapping.
gep13 pushed a commit to gep13/rhino-licensing that referenced this issue Sep 15, 2022
@corbob @gep13
(chocolatey#18) Remove licenses that are not used
39b49ba 
Remove the license types that Chocolatey doesn't use.

This includes Floating and Subscription licenses.
Removes validating with a server (subscription).
Also removes the license reassertion that's caused issues in the past.
gep13 pushed a commit to gep13/rhino-licensing that referenced this issue Sep 15, 2022
@corbob @gep13
(chocolatey#18) Update Chocolatey.Cake.Recipe version
cee11a5 
Update to use the new Chocolatey.Cake.Recipe version.
Suppress creation of SolutionVersion.cs
Update Readme with current information about running tests.
gep13 pushed a commit to gep13/rhino-licensing that referenced this issue Sep 15, 2022
@corbob @gep13
(chocolatey#18) Revamp tests
923e5d5 
Update tests to split out generation and validation.
Created xml files to verify aspects of generation and validation.
Updated readme with instructions to generate test license files.
gep13 pushed a commit to gep13/rhino-licensing that referenced this issue Sep 15, 2022
@corbob @gep13
(chocolatey#18) Add script to build all dependent projects
6444c65 
Add a script that will build every project that  depend on Rhino.Licensing.
gep13 pushed a commit to gep13/rhino-licensing that referenced this issue Sep 15, 2022
@corbob @gep13
(chocolatey#18) Add test for mapping of LicenseType to int
8a3b2e7 
We use the int for the database, this ensures we don't accidentally
change that mapping.
@gep13 gep13 closed this as completed in #20 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - Review BreakingChange
Projects
None yet
Milestone
2.0.0
2 participants
@gep13 @corbob