Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#422) yarn preview-upgrade improvements #423

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Oct 3, 2024

Description Of Changes

This adjust the yarn preview-upgrade command to first remove the yarn.lock file in the chosen repository before upgrading choco-theme. By doing this, it ensures all dependencies are upgraded of choco-theme and not just choco-theme itself. This is desired in most cases.

Also, the CCM repository has been added to the list of configs, so that is caught when using the --all or --ccm flag on yarn commands.

Motivation and Context

This command was not properly updating dependences and needed to be fixed.

Testing

  1. Pull down this branch.
  2. On CCM, make sure you are on the develop branch and you have the latest changes pulled in from upstream.
  3. In choco-theme, run yarn preview-upgrade 0.8.1 --ccm
  4. You should see multiple things changed in the yarn.lock file in the CCM project repository. Do not commit anything, we're just checking to see that it caught "things".

Operating Systems Testing

Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #422

This adjust the yarn preview-upgrade command to first remove the
yarn.lock file in the chosen repository before upgrading choco-theme.
By doing this, it ensures all dependencies are upgraded of choco-theme
and not just choco-theme itself. This is desired in most cases.

Also, the CCM repository has been added to the list of configs, so that
is caught when using the --all or --ccm flag on yarn commands.
@st3phhays st3phhays self-assigned this Oct 3, 2024
@st3phhays
Copy link
Member Author

This is draft due to not being really needed right now. I think this would be best to review in a few days, when some of the dependencies have been bumped by the maintainers. This will give us a better view of how it upgrade dependencies.

@st3phhays st3phhays marked this pull request as ready for review October 9, 2024 19:55
Copy link
Contributor

@alexaveldanez alexaveldanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alexaveldanez alexaveldanez merged commit 17d669f into chocolatey:main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn preview-upgrade command doesn't upgrade dependencies
2 participants