-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#415)(#416)(#417)(#418) choco-theme 0.8.1 #420
Conversation
This updates the yarn npm audit command to include all severity types, scan dependencies recursively, and also ignores the known vulnerability in sweetalert2. This command has been added to the readme, which can be ran locally after `yarn` has been ran. In addition, this has been updated in the audit.yaml file that is ran before choco-theme is released.
This updates the path to which the PT Sans font should be copied to on the docs site. This removes the duplicate 'fons' in the path. This allows the font to be copied correctly when `yarn choco-theme` is ran on the docs site.
This upgrades to the latest version of ESLint. With this upgrade, the format of the config file change to a `eslint.config.mjs` file. A tool was used by ESLint to convert over the existing .eslintrc.js file. More information on the conversion can be found at https://eslint.org/docs/latest/use/configure/migration-guide. After this upgrade of ESLint, ESLint was ran and tested by making purposeful changes to ensure that errors were caught. This worked successfully, and also found an actual error that was fixed.
This PR is to remain in draft until all other PRs that use this are have been reviewed and approved. This is to ensure that everything that uses this version of choco-theme has been tested and passes. |
a06d960
to
8714cf8
Compare
This fixes a few small errors in the preview scripts to allow them to run as they are intended. There was a `)` in the wrong place that has been moved.
8714cf8
to
0ac2cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
0ac2cb0
to
afd5f7d
Compare
This upgrades choco-theme to 0.8.1. With this upgrade, typescript and purgecss were upgraded to remove any possible vulnerabilities. Other than that, no specific changes were made although the compiled code changed slightly due to additional dependencies being upgraded to minor versions by removing and regenerating the yarn.lock file.
afd5f7d
to
0dc2578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description Of Changes
Motivation and Context
There were a few dependencies that needed upgraded to allow the
yarn npm audit
command to pass. We want to ship up to date dependencies and remove any vulnerabilities. In addition, the font path to the docs needed fixed to ensure fonts were shown the same for all users.Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue