Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#407) Retain CollapseButton CSS #409

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Jun 12, 2024

Description Of Changes

The CSS for the CollapseButton was getting deleted and needed to be added
to the safelist for purgeCSS. Now, with this in place, all buttons show
as they should with the correct styles.

Motivation and Context

We need the CollapseButton component to show correctly.

Testing

Follow instructions at chocolatey/docs#1009

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

#407

The CSS for the CollapseButton was getting deleted and needed to be added
to the safelist for purgeCSS. Now, with this in place, all buttons show
as they should with the correct styles.
@st3phhays st3phhays self-assigned this Jun 12, 2024
@st3phhays st3phhays marked this pull request as ready for review June 12, 2024 23:12
@st3phhays st3phhays requested a review from corbob June 13, 2024 01:38
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corbob corbob merged commit 368fc0f into chocolatey:main Jun 13, 2024
3 checks passed
@corbob
Copy link
Member

corbob commented Jun 13, 2024

Thanks for getting this fixed up @st3phhays 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants