Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#285)(#363) Add 12 Days of Chocolatey Packaging Banner #364

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Dec 12, 2023

Description Of Changes

  • This adds a top banner to promote the 12 Days of Chocolatey Packaging.
  • Pins Bootstrap types version

Motivation and Context

We want to promote the 12 Days of Chocolatey Packaging over the holidays.

Testing

  1. Run the website from this PR: https://github.com/chocolatey/chocolatey.org/pull/295
  2. Ensure the top banner appears with the correct text, is green, and takes you to the blog when clicked.

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

This pins the types used by Bootstrap. We have pinned the Bootstrap
library, and it's types should be as well. This was causing dependency
errors.
@st3phhays st3phhays self-assigned this Dec 12, 2023
@st3phhays st3phhays requested review from pauby and corbob and removed request for pauby December 12, 2023 20:29
This adds a top banner to promote the 12 Days of Chocolatey Packaging.
partials/AlertText.txt Outdated Show resolved Hide resolved
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corbob corbob merged commit 25f7562 into chocolatey:main Dec 14, 2023
2 checks passed
@corbob
Copy link
Member

corbob commented Dec 14, 2023

Thanks for getting this added @st3phhays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants