Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#360) Styles to Support the Use Cases > Server #361

Merged
merged 1 commit into from
Nov 3, 2023
Merged

(#360) Styles to Support the Use Cases > Server #361

merged 1 commit into from
Nov 3, 2023

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Oct 31, 2023 •
edited
Loading

Description Of Changes

The changes here are used and will be used on the new Use Cases > Server page, and future additional pages.

  • Add a Use Cases > Server page with associated styles - see #360
    • Adds the new polyfill for use of balancing text until this is natively supported with CSS in all browsers.
    • Adds new background colors to be used on icons backgrounds.
    • Adds support for adjusting the terminal cursor size to accommodate smaller text in terminal animation cards by adding the terminal-sm-cursor class.
    • Switched to use the $border-color SASS variable as opposed to custom CSS to set the default border color.

Motivation and Context

The styes added here are needed for the new page, and will be used on future pages as well.

Testing

To test these changes, follow the instructions on the chocolatey.org PR.

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@st3phhays st3phhays self-assigned this Oct 31, 2023
@st3phhays
(chocolatey#360) Styles to Support the Use Cases > Server
2338b67 
The changes here are used and will be used on
the new Use Cases > Server page, and future
additional pages.

Introduced is a CSS pollyfill that will balance
text automatically based on the screen width.
In the future, once this is supported in all
browsers with CSS, this can be removed.

A few new background colors have been added for
usage on icons to better outline problem/solution
paragraphs.
@st3phhays st3phhays requested a review from gep13 November 2, 2023 15:39
@st3phhays st3phhays marked this pull request as ready for review November 2, 2023 15:40
@gep13
Copy link
Member

gep13 commented Nov 3, 2023

@st3phhays I have just taken this for a spin, and it all looks good to me!

gep13
gep13 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Nov 3, 2023

I will leave this for you to merge, and to do what is necessary to pull this through to the related PR.

@st3phhays st3phhays merged commit aa2f8ba into chocolatey:main Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees

@st3phhays st3phhays

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st3phhays @gep13