-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(doc) Confirm WCAG Compliance #1054
base: develop
Are you sure you want to change the base?
Conversation
694b7df
to
3d5a952
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pauby since there is an issue associated with this PR that is already on the 2.2.0 milestone, this PR shouldn't also be added to the milestone. Or, should we remove the linked issue from the milestone, and close it out as not being completed, and leave this documentation PR in that milestone? |
This was my fault. I added this PR then remembered I should add the issue instead and then forgot to remove this again. Removed this PR. |
Thanks for doing that. Regarding, #645, I am not sure if it is right to say that this PR addresses that issue. Chocolatey GUI has not been tested with a suitable screenreader, and the accessibility changes haven't been made. I think the wording of that issue needs to be changed, or this PR should not be attributed to that issue, and instead it should be closed. |
My thinking on the issue being 'fixed' by the PR was that as Chocolatey CLI should be used when accessibility tools are used, and we are stating that in the 'About' screen, the issue was no longer required. I attributed the issue as the changes in this PR is the reason it a being closed. I have no problem with not linking it in the PR as it being 'fixed', instead closing it by referencing the PR in the closure comment. |
Description Of Changes
Confirms WCAG Compliance of Chocolatey GUI and what to use for accessibility.
Motivation and Context
Chocolatey GUI is not WCAG compliant.
Testing
N/A - this is markdown.
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue
Fixes #645