Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) Confirm WCAG Compliance #1054

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pauby
Copy link
Member

@pauby pauby commented Jun 25, 2024

Description Of Changes

Confirms WCAG Compliance of Chocolatey GUI and what to use for accessibility.

Motivation and Context

Chocolatey GUI is not WCAG compliant.

Testing

N/A - this is markdown.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #645

@pauby pauby requested review from ferventcoder and gep13 June 25, 2024 10:04
@pauby pauby added this to the 2.2.0 milestone Jun 25, 2024
@pauby pauby force-pushed the doc/confirm-wcag-compliance branch from 694b7df to 3d5a952 Compare June 26, 2024 13:34
gep13
gep13 previously approved these changes Jun 26, 2024
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Jun 26, 2024

@pauby since there is an issue associated with this PR that is already on the 2.2.0 milestone, this PR shouldn't also be added to the milestone.

Or, should we remove the linked issue from the milestone, and close it out as not being completed, and leave this documentation PR in that milestone?

@pauby
Copy link
Member Author

pauby commented Jun 26, 2024

This was my fault. I added this PR then remembered I should add the issue instead and then forgot to remove this again.

Removed this PR.

@pauby pauby removed this from the 2.2.0 milestone Jun 26, 2024
@gep13
Copy link
Member

gep13 commented Jun 27, 2024

Removed this PR.

Thanks for doing that.

Regarding, #645, I am not sure if it is right to say that this PR addresses that issue. Chocolatey GUI has not been tested with a suitable screenreader, and the accessibility changes haven't been made. I think the wording of that issue needs to be changed, or this PR should not be attributed to that issue, and instead it should be closed.

@pauby
Copy link
Member Author

pauby commented Jun 27, 2024

My thinking on the issue being 'fixed' by the PR was that as Chocolatey CLI should be used when accessibility tools are used, and we are stating that in the 'About' screen, the issue was no longer required.

I attributed the issue as the changes in this PR is the reason it a being closed.

I have no problem with not linking it in the PR as it being 'fixed', instead closing it by referencing the PR in the closure comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Test Chocolatey GUI with screen-readers
2 participants