-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user/fcitx5-rime: new package #3516
Open
bjin
wants to merge
4
commits into
chimera-linux:master
Choose a base branch
from
bjin:add-rime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+199
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjin
changed the title
new packages: Add rime & fcitx5-rime
user/fcitx5-rime: new package
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
q66
reviewed
Jan 24, 2025
i posted some initial review, once you've addressed these i will go over it again for anything i missed (it's hard to review a big PR all at once) |
addressed all comments, squashed changes into corresponding commits and rebased, force pushed This PR is ready to be reviewed. |
updated to ignore update-check for "rime-data" package |
updated fcitx5-rime to depends on the latest fcitx5 5.1.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds four packages to user repo. It adds rime Chinese input method library and fcitx5-rime for its use in fcitx5 input method frontend.
This is my first contribution to cports, so please tell if something is not handled properly. Here are things I have done:
Among these four packages, the most controversial one is probably "rime-data". This package contains the input method schema data for rime. But there is no official release for it, as it contains multiple git repositories, and each one is user contributed and updating on a daily base.
Also, fcitx5-rime 5.1.10 was released two days ago but it requires a newer version of fcitx5 than the one cports ships. Since the fcitx5 package is in main repo, I plan to open another PR to upgrade both package (and all dependents) after this PR is merged.
Checklist
Before this pull request is reviewed, certain conditions must be met.
The following must be true for all changes:
The following must be true for template/package changes:
The following must be true for new package submissions: