Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user/fcitx5-rime: new package #3516

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

bjin
Copy link

@bjin bjin commented Jan 24, 2025

Description

This PR adds four packages to user repo. It adds rime Chinese input method library and fcitx5-rime for its use in fcitx5 input method frontend.

This is my first contribution to cports, so please tell if something is not handled properly. Here are things I have done:

  1. Verify the package content (only list of filenames) against the alpine packages, and the result matches in general.
  2. Install on my local machine and verify that these package work properly.
  3. Format with black code formatter.
  4. Enabled "vis" and "cfi" hardening options by trial-and-error.

Among these four packages, the most controversial one is probably "rime-data". This package contains the input method schema data for rime. But there is no official release for it, as it contains multiple git repositories, and each one is user contributed and updating on a daily base.

  1. I choose to package all these schema in single package, this makes template cleaner.
  2. I choose to use date as the pkgver (which the latest commit date of all git repositories being tracked).
  3. I choose to not package the plum tool (the (rime-install)[https://github.com/rime/plum/blob/master/rime-install]) since the script is mostly written to work in a working git repository.

Also, fcitx5-rime 5.1.10 was released two days ago but it requires a newer version of fcitx5 than the one cports ships. Since the fcitx5 package is in main repo, I plan to open another PR to upgrade both package (and all dependents) after this PR is merged.

Checklist

Before this pull request is reviewed, certain conditions must be met.

The following must be true for all changes:

The following must be true for template/package changes:

  • I have read Packaging.md
  • I have built and tested my changes on my machine

The following must be true for new package submissions:

  • I will take responsibility for my template and keep it up to date

@bjin bjin changed the title new packages: Add rime & fcitx5-rime user/fcitx5-rime: new package Jan 24, 2025
user/fcitx5-rime/template.py Outdated Show resolved Hide resolved
user/rime/template.py Outdated Show resolved Hide resolved
user/rime-data/template.py Outdated Show resolved Hide resolved
user/rime-data/template.py Outdated Show resolved Hide resolved
user/rime-data/template.py Outdated Show resolved Hide resolved
user/rime-data/template.py Outdated Show resolved Hide resolved
user/rime-data/template.py Outdated Show resolved Hide resolved
user/leveldb/template.py Outdated Show resolved Hide resolved
@q66
Copy link
Member

q66 commented Jan 24, 2025

i posted some initial review, once you've addressed these i will go over it again for anything i missed (it's hard to review a big PR all at once)

@bjin
Copy link
Author

bjin commented Jan 25, 2025

addressed all comments, squashed changes into corresponding commits and rebased, force pushed

This PR is ready to be reviewed.

@bjin
Copy link
Author

bjin commented Jan 26, 2025

updated to ignore update-check for "rime-data" package

@bjin
Copy link
Author

bjin commented Jan 27, 2025

updated fcitx5-rime to depends on the latest fcitx5 5.1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants