Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usr/lshw: new package #3502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Guiglin
Copy link
Contributor

@Guiglin Guiglin commented Jan 20, 2025

Description

lshw: HardWare LiSter for Linux: lshw is a small tool to provide detailed information on the hardware configuration of the machine. It can report exact memory configuration, firmware version, mainboard configuration, CPU version and speed, cache configuration, bus speed, etc.

Checklist

Before this pull request is reviewed, certain conditions must be met.

The following must be true for all changes:

The following must be true for template/package changes:

  • I have read Packaging.md
  • I have built and tested my changes on my machine

The following must be true for new package submissions:

  • I will take responsibility for my template and keep it up to date

user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
sha256 = "06d9cf122422220e5dc94e8ea5b01816a69bb6b59368f63d7f21fff31fc6922a"
hardening = ["vis", "cfi"]
# no tests available and may fail to link ./core/liblshw.a
options = ["!check", "!linkparallel"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may fail to link how

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the problem once. Hard to reproduce. But I remarked that the template file of void linux has this config too so I concluded it may fail not just for me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it doesn't, it disables parallel build, not parallel linking

Copy link
Contributor Author

@Guiglin Guiglin Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but it does not seem they have the option to disable parallel link only, did they? Anyway, do you prefer I remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you misunderstand what this option does

if there's a race in the build system this won't fix anything because it only prevents the linker process from creating parallel threads

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arf ok then completely useless here. I'll remove it since I fail to reproduce any parallel build issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
user/lshw/template.py Outdated Show resolved Hide resolved
@Guiglin Guiglin force-pushed the gba/lshw branch 6 times, most recently from 047770a to 1e9862a Compare January 22, 2025 10:09
@Guiglin Guiglin requested a review from q66 January 23, 2025 21:20
make_use_env = True
hostmakedepends = ["gettext", "pkgconf"]
makedepends = [
"gettext-devel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably don't need gettext-devel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, removed

url = "https://ezix.org/project/wiki/HardwareLiSter"
source = f"https://www.ezix.org/software/files/lshw-B.{pkgver}.tar.gz"
sha256 = "06d9cf122422220e5dc94e8ea5b01816a69bb6b59368f63d7f21fff31fc6922a"
# no tests available and may fail to link ./core/liblshw.a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment is misleading now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, removed



def post_install(self):
self.install_file(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these files should go to gtk-lshw and they don't currently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a patch to correctly install file when doing a make install-gui and add lines to grab those files in the subpackage


@subpackage("gtk-lshw")
def _(self):
self.subdesc = "GTK ui"
Copy link
Member

@q66 q66 Jan 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTK UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"linux-headers",
"zlib-ng-compat-devel",
]
pkgdesc = "Hardware Lister"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lister should be lowercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants