-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usr/lshw: new package #3502
base: master
Are you sure you want to change the base?
usr/lshw: new package #3502
Conversation
user/lshw/template.py
Outdated
sha256 = "06d9cf122422220e5dc94e8ea5b01816a69bb6b59368f63d7f21fff31fc6922a" | ||
hardening = ["vis", "cfi"] | ||
# no tests available and may fail to link ./core/liblshw.a | ||
options = ["!check", "!linkparallel"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may fail to link how
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the problem once. Hard to reproduce. But I remarked that the template file of void linux has this config too so I concluded it may fail not just for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no it doesn't, it disables parallel build, not parallel linking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but it does not seem they have the option to disable parallel link only, did they? Anyway, do you prefer I remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you misunderstand what this option does
if there's a race in the build system this won't fix anything because it only prevents the linker process from creating parallel threads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arf ok then completely useless here. I'll remove it since I fail to reproduce any parallel build issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
047770a
to
1e9862a
Compare
user/lshw/template.py
Outdated
make_use_env = True | ||
hostmakedepends = ["gettext", "pkgconf"] | ||
makedepends = [ | ||
"gettext-devel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably don't need gettext-devel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, removed
user/lshw/template.py
Outdated
url = "https://ezix.org/project/wiki/HardwareLiSter" | ||
source = f"https://www.ezix.org/software/files/lshw-B.{pkgver}.tar.gz" | ||
sha256 = "06d9cf122422220e5dc94e8ea5b01816a69bb6b59368f63d7f21fff31fc6922a" | ||
# no tests available and may fail to link ./core/liblshw.a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment is misleading now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, removed
user/lshw/template.py
Outdated
|
||
|
||
def post_install(self): | ||
self.install_file( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these files should go to gtk-lshw and they don't currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a patch to correctly install file when doing a make install-gui
and add lines to grab those files in the subpackage
user/lshw/template.py
Outdated
|
||
@subpackage("gtk-lshw") | ||
def _(self): | ||
self.subdesc = "GTK ui" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTK UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
user/lshw/template.py
Outdated
"linux-headers", | ||
"zlib-ng-compat-devel", | ||
] | ||
pkgdesc = "Hardware Lister" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lister should be lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Description
lshw: HardWare LiSter for Linux: lshw is a small tool to provide detailed information on the hardware configuration of the machine. It can report exact memory configuration, firmware version, mainboard configuration, CPU version and speed, cache configuration, bus speed, etc.
Checklist
Before this pull request is reviewed, certain conditions must be met.
The following must be true for all changes:
The following must be true for template/package changes:
The following must be true for new package submissions: